Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major interface and Metabase client refactor #196

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Conversation

gouline
Copy link
Owner

@gouline gouline commented Dec 14, 2023

  • Remove DbtInterface and MetabaseInterface (call DbtReader and MetabaseClient directly instead)
  • Manifest parser is now the only dbt parser available: this was a long time coming, project/folder parser was no longer maintained for many versions, so it's being removed before the major version
  • Move CLI code into main.py to simplify running locally (e.g. via python3 -m dbtmetabase)
  • Minimise duplication in CLI setup by initialising DbtReader and MetabaseClient once
  • Simplify Metabase parameters (e.g. host/use_http becomes url)
  • Refactor MetabaseClient into job-specific context, to improve separation of concern
  • Minor consistency and typing fixes/improvements

@gouline gouline changed the title Major interface refactor Major interface and Metabase client refactor Dec 15, 2023
@gouline gouline marked this pull request as ready for review December 15, 2023 03:42
@gouline gouline merged commit a5bfdfa into master Dec 15, 2023
1 check passed
@gouline gouline deleted the refactor-interface branch December 15, 2023 03:42
@gouline
Copy link
Owner Author

gouline commented Jan 9, 2024

Fixes #185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant