feat: allow column description to be overwritten #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, if you're adding it for columns, it should be there for tables too. Add some unit tests as well. |
|
I've added it to the Model and updated the tests. WDYT? |
gouline
requested changes
Nov 26, 2024
gouline
reviewed
Nov 27, 2024
gouline
approved these changes
Nov 27, 2024
Merged
gouline
added a commit
that referenced
this pull request
Nov 27, 2024
* feat: allow column description to be overwritten (#291) * feat: allow column description to be overwritten * feat: Consider Model description as well * chore: Update tests * chore: Column test * fix: fmt * fix: test v2 manifest instead of v12 * Apply suggestions from code review --------- Co-authored-by: Mike Gouline <[email protected]> * fix type issue --------- Co-authored-by: Felipe Guilherme Sabino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
descriptionto be set usingmetabase.descriptionat column and table level, prioritizing it when set.Feel free to suggest any possible changes, but just to give you an idea of our use case. We might (and need) different descriptions for columns/tables due to: language, size (dbt documentation allows for more flexibility).
I might update the PR to include the same behavior at Table level.Done.