Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PYIC-6243: dcmaw async poll can return journey response #2644

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

PYIC-6243: dcmaw async poll can return journey response #2644

wants to merge 10 commits into from
+326 −118

Conversation

MikeCollingwood
Copy link
Contributor

@MikeCollingwood MikeCollingwood commented Oct 29, 2024 •
edited
Loading

Proposed changes

What changed

  • Modify CheckMobileAppVcReceiptHandler to return a journey response after more checks

Why did it change

  • This would allow core-front to take the result and prime the "Checking your details" page with the event to map to the correct path.

Issue tracking

@MikeCollingwood MikeCollingwood requested review from a team as code owners October 29, 2024 15:47
@MikeCollingwood MikeCollingwood force-pushed the pyic-6243-poc branch 2 times, most recently from 1042280 to 0fad243 Compare October 30, 2024 11:00
@MikeCollingwood MikeCollingwood mentioned this pull request Oct 30, 2024
Merged
Base automatically changed from pyic-6243 to main October 31, 2024 08:01
A-Rashid9
A-Rashid9 previously approved these changes Oct 31, 2024
View reviewed changes
@A-Rashid9 A-Rashid9 dismissed their stale review October 31, 2024 17:03

Conflict on the branch

@MikeCollingwood MikeCollingwood marked this pull request as draft November 1, 2024 12:05
@MikeCollingwood MikeCollingwood changed the title PYIC-6243-POC: Modify CheckMobileAppVcReceiptHandler to return a journey response after more checks PYIC-6243: Mobile App check lambda returns journey response Nov 11, 2024
@MikeCollingwood MikeCollingwood marked this pull request as ready for review November 11, 2024 14:45
@MikeCollingwood MikeCollingwood changed the title PYIC-6243: Mobile App check lambda returns journey response PYIC-6243: dcmaw async poll can return journey response Nov 11, 2024
blakeyp
blakeyp previously approved these changes Nov 15, 2024
View reviewed changes
blakeyp
blakeyp previously approved these changes Nov 15, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@A-Rashid9 A-Rashid9 A-Rashid9 left review comments

@blakeyp blakeyp blakeyp left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeCollingwood @blakeyp @A-Rashid9