PYIC-7329: Change .reset() to resetHistory for safety

govuk-one-login · Nov 11, 2024 · 8457f34 · 8457f34
1 parent 7290d31
commit 8457f34
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/app/credential-issuer/middleware.test.ts b/src/app/credential-issuer/middleware.test.ts
@@ -45,7 +45,7 @@ describe("credential issuer middleware", () => {
   beforeEach(() => {
     next.resetHistory();
     coreBackServiceStub.postCriCallback.resolves({});
-    ipvMiddlewareStub.handleBackendResponse.reset();
+    ipvMiddlewareStub.handleBackendResponse.resetHistory();
   });
 
   (

diff --git a/src/app/ipv/tests/formHandleCoiAndUpdateDetailsCheck.test.ts b/src/app/ipv/tests/formHandleCoiAndUpdateDetailsCheck.test.ts
@@ -24,7 +24,7 @@ describe("handle update details/COI form checkbox", () => {
 
   beforeEach(() => {
     next.resetHistory();
-    coreBackServiceStub.getProvenIdentityUserDetails.reset();
+    coreBackServiceStub.getProvenIdentityUserDetails.resetHistory();
   });
 
   const updateDetailsPageTestCases = [

diff --git a/src/app/ipv/tests/handleJourneyPageRequest.test.ts b/src/app/ipv/tests/handleJourneyPageRequest.test.ts
@@ -32,7 +32,7 @@ describe("handleJourneyPageRequest", () => {
 
   beforeEach(() => {
     next.resetHistory();
-    coreBackServiceStub.getProvenIdentityUserDetails.reset();
+    coreBackServiceStub.getProvenIdentityUserDetails.resetHistory();
   });
 
   context("handling page-ipv-reuse journey route", () => {

diff --git a/src/app/ipv/tests/processAction.test.ts b/src/app/ipv/tests/processAction.test.ts
@@ -32,8 +32,8 @@ describe("processAction", () => {
   );
 
   beforeEach(() => {
-    coreBackServiceStub.postJourneyEvent.reset();
-    coreBackServiceStub.postAction.reset();
+    coreBackServiceStub.postJourneyEvent.resetHistory();
+    coreBackServiceStub.postAction.resetHistory();
   });
 
   it("should throw an error when receiving an unexpected backend response", async function () {

diff --git a/src/handlers/error-handler.test.ts b/src/handlers/error-handler.test.ts
@@ -28,7 +28,7 @@ describe("Error handlers", () => {
 
   beforeEach(() => {
     next.resetHistory();
-    axiosStub.isAxiosError.reset();
+    axiosStub.isAxiosError.resetHistory();
   });
 
   describe("pageNotFoundHandler", () => {