Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BAU] - Add error handling for session and token expiry #137

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KaraokeStu
Copy link
Contributor

Proposed changes

What changed

  • Updated Issue Credential Handler to correctly sent 403 access denied if items have expired
  • Updated all CRI specific lambdas to send errors using the "IPV-Core" method

Why did it change

In order to align with RFC 6749 - The OAuth 2.0 Authorization Framework , we need to ensure when authorization codes are created, they have an expiry time set.

As per the RFC (above), this expiry time should have a maximum recommended TTL of 10 minutes.

Authorization codes must only be used once.
Once successfully changed for a bearer token, the authorization code must be expired.

Issue tracking

@KaraokeStu KaraokeStu requested a review from a team as a code owner June 17, 2022 10:58
@KaraokeStu KaraokeStu temporarily deployed to di-ipv-cri-dev June 17, 2022 10:58 Inactive
@merlinc merlinc marked this pull request as draft April 13, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant