Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bau added extra pre commit checks #790

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vam-gds
Copy link
Contributor

@vam-gds vam-gds commented Nov 3, 2023

Proposed changes

What changed

Bau added extra pre commit checks

Why did it change

Bau added extra pre commit checks

Issue tracking

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed
  • Documented in the README
  • Added to deployment repository
  • Added to local startup repository

Other considerations

  • Update README with any new instructions or tasks

@vam-gds vam-gds requested a review from a team November 3, 2023 10:19
@jkunle
Copy link
Contributor

jkunle commented Nov 6, 2023

Please when you update this PR, can give some context around the changes. Our pre-merge integration test is broken. But pre-commit can be fixed

@CharlesIC
Copy link
Contributor

The extra PR checks should be a separate PR

@CharlesIC CharlesIC marked this pull request as draft November 16, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants