Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIME-843 - Adapted actions to use onelogin actions and create preview stacks for testing current branch #143

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

smsgds
Copy link
Contributor

@smsgds smsgds commented Jun 28, 2024

Proposed changes

What changed

- where possible adapted actions to use https://github.com/govuk-one-login/github-actions
- applied linting fix for issues highlighted by pre-commit checks
- removed duplicate smoke test action, named remaining smoke-test-build
- combined pre-merge checks into check-pr (based on hmrc-kbv-api)
- - pre-commit - runs all the pre-commit checks
- - - Add file path in .pre-commit-config.yaml so checkov has files to scan
- - java-build-check - compiles classes and caches the gradle build output to enable several works flows to run in parralel without needing to pull and build
- - corrected cache paths for gradle steps and enabled caching use where possible
- - - java-style-check - spotless check
- - - unit-tests - java unit tests and coverage report.
- - - sonar-scan - on the current branch (if unit-tests have passed)
- - - pact-tests - on the current branch
- - pre-merge-integration-tests deploys and stack runs the api tests against it
- - deploy-preview-stack - deployment of preview stack configured of local test (requires pre-merge tests to pass)
- switch aws-actions/setup-sam to use-installer so caching is used

Why did it change

To enable preview stack deployment for each PR raised and align passport-cri-api workflows and align to using govuk-one-login/github-actions

Issue tracking

… stacks for testing current branch

	- where possible adapted actions to use https://github.com/govuk-one-login/github-actions
	- applied linting fix for issues highlighted by pre-commit checks
	- removed duplicate smoke test action, named remaining smoke-test-build
	- combined pre-merge checks into check-pr (based on hmrc-kbv-api)
	- - pre-commit - runs all the pre-commit checks
	- - java-build-check - compiles classes and caches the gradle build output to enable several works flows to run in parralel without needing to pull and build
	- - corrected cache paths for gradle steps and enabled caching use possible
	- - - java-style-check - spotless check
	- - - unit-tests - java unit tests and coverage report.
	- - - sonar-scan - on the current branch (if unit-tests have passed)
	- - - pact-tests - on the current branch
	- - pre-merge-integration-tests deploys and stack runs the api tests against it
	- - deploy-preview-stack - deployment of preview stack configured of local test (requires pre-merge tests to pass)
Copy link

sonarcloud bot commented Jul 8, 2024

@smsgds smsgds merged commit 9197216 into main Jul 8, 2024
12 of 13 checks passed
@smsgds smsgds deleted the LIME-843 branch July 8, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants