[LIME-1114] Added sessionID validation UUID check #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahHillGDS
temporarily deployed
to
development
GitHub Actions
Inactive
SarahHillGDS
force-pushed
the
LIME-1114-fix
branch
from
3dc809a
to
304c5f0
Compare
|
ElliotMurphyGDS
approved these changes
Sep 26, 2024
smsgds
approved these changes
Oct 2, 2024
SarahHillGDS
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue during testing where an empty value for the session_id header was returning Unexpected server error.
Update CheckPassportHandler.java to use UUID so it catches incorrect strings/special chars
What changed
Added UUID check for sessionID in CheckPassportHandler.java
Added unit test for invalid sessionID in CheckPassportHandlerTest.java
Why did it change
Issue tracking
Other considerations