feat: DCMAW-10311 generate key pair #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BiancaMihaila
approved these changes
Oct 25, 2024
obinns-dd
reviewed
Oct 25, 2024
- a Firebase implementation of the AttestationManager is created with 'empty' methods - `KeystoreManager` created to create a way to interact with the Keystore and use keys from it. Currently it generates an EC keypair on initialization if one does not already exist
Update AppAuthPresentTest from calling external Activity Resolves: 10311
Move appcheck usecase package under the integrity package in the test source set to match the package structure in the main source set Remove extra login package in the test source set Resolves: 10311
Move the appcheck usecase package from appcheck to directly under the integrity package Update the test source set to match Resolves: 10311
Update libs.versions.toml to remove the GDS networking library dependency Update build.gradle.kts to remove usage of the GDS networking dependency Add AttestationClient to use in place of GenericHttpClient Add JWK object to hold the relevant details for the attestation JWK Swap from GenericHttpClient to AttestationClient Update tests Resolves: 10311
ThomasIent
force-pushed
the
DCMAW-10311-generate-key-pair
branch
from
b9f16c0
to
23cf46f
Compare
Update build.gradle.kts to include a property extra for buildLogicDir Resolves: 10311
Update build.gradle.kts to remove use of mockito.core (it is included in mockito.kotlin) Update test classes to use kotlin.test Resolves: 10311
Rename AttestationApiCal to AttestationCaller Combine Attestation Client and AttestationCaller into one interface Update KeystoreManager to include getter for private key Update tests to match changes Resolves: 10311
Update settings.gradle.kts to revert back to what it was Resolves: 10311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMAW-10311
Description of changes
KeystoreManagercreated to create a way to interact with the Keystore and use keys from it. Currently it generates an EC keypair on initialization if one does not already existEvidence against the ACs will be found in the One-Login codebase although even there it will be difficult to really show the keys being created. Hopefully the tests present here are covering the desired behaviour.