Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Amend param type to Int #99

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Amend param type to Int #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e6eb6c
fix: Amend parameter type to Int in AttestationResponse.Success
Nov 8, 2024
5d582d1
test: Amend tests
Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...Test/java/uk/gov/android/authentication/integrity/FirebaseClientAttestationManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ class FirebaseClientAttestationManagerTest {
whenever(caller.call(any(), any()))
.thenReturn(AttestationResponse.Success(
"Success",
"0"
0
))
val result = clientAttestationManager.getAttestation()

assertEquals(AttestationResponse.Success("Success", "0"),
assertEquals(AttestationResponse.Success("Success", 0),
result)
}

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/uk/gov/android/authentication/integrity/model/AttestationResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ sealed class AttestationResponse {
@JsonNames("client_attestation")
val attestationJwt: String,
@JsonNames("expires_in")
val expiresIn: String
val expiresIn: Int
) : AttestationResponse()
data class Failure(val reason: String, val error: Throwable? = null) : AttestationResponse()
}