Feat: DCMAW 10331 Update copy on the Sign out confirmation page (with Wallet copy) #117
+766
−1,013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update m3 Typography to align with what is set for m2 based on the migration documentation Update m3 Typography to include a preview of all text styles Resolves: 10331
Rename Shape to Shapes to match m2 Update m3 Shapes to align with what is set for m2 based on the migration documentation Update m3 Shapes to include a preview of all shapes Resolves: 10331
Add ColorScheme to pull colors out of Theme Add small documentation on how m2 and m3 colors compare Resolves: 10331
Remove the use of the Keep annotation and add proguard rules instead Resolves: 10331
Add CloseButton composable to the components m3 buttons package Add CloseButtonTest to test CloseButton Update strings.xml to include content description Update Dimensions to include closeButtonSize resource Resolves: 10331
Update Buttons to more closely match the Figma designs Update ButtonType to include ERROR type, swap TERTIARY to QUATERNARY (it doesn't use tertiary colors) Update ButtonParameters to remove unused parameters Update ButtonProvider to group ButtonParameters variations by ButtonType This has required updating Color, ColorScheme, Typography, and Dimensions Resolves: 10331
Delete resources for non-compose ui Resolves: 10331
Update build.gradle.kts to include android orchestrator Resolves: 10331
Add ShapesTest to cover the Shapes compose preview Update Shapes with a small bit of tidying Update Theme to fix a small mistake Resolves: 10331
Update BulletList to remove usage of M3 classes Resolves: 10331
Rename M3 HeadingSize Classes to match M3 naming convention Resolves: 10331
Delete duplicate drawable resources in pages Auto-layout all drawable resources (Small format change in build.gradle.kts) Resolves: 10331
ThomasIent
force-pushed
the
feat/DCMAW-10331
branch
from
f600cd9
to
f4092d5
Compare
Resolves: 10331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCMAW-10331: Update copy on the Sign out confirmation page (with Wallet copy)
Description of changes:
Evidence of the change
Old Buttons
New Buttons
Old Colors
New Colors
Old Headings
New Headings
Checklist
Before creating the pull request
draftpull request if it's not ready for review.Before the CODEOWNERS review the pull request
Before merging the pull request