Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests around showQuestionNumbers - DC #68

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ChopinDavid
Copy link
Contributor

@ChopinDavid ChopinDavid commented May 15, 2023

I added a failing test that could be re-written to pass once #69 is resolved.

@ChopinDavid
Copy link
Contributor Author

ChopinDavid commented May 22, 2023

I went ahead and rebased main and changed the unnecessarily failing test to a TODO. It would be very nice to get this merged in as it is low-risk (only added test coverage) and would prevent having to resolve merge conflicts in the future. @goxiaoy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants