add string formatters so [Object Object] does not show in output #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @paulhiggs , thank you! I think the branch misses some commits as I see no code change! |
|
Hmmm, some merge or pull request has not gone as expected.. Checking! |
|
The commit d1cb88f solve this - did not make it into the previous push |
|
Thank you @paulhiggs. I've changed the way we visualize NALUs. The CI upgrade should be done out of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPS and PPS in avcV and nalu_arrays in hvcC are objects, so the basic output format in generateBoxTable(). Adding a toString() formatter to these properties with some basic HTML fixes this.