Skip to content

Commit

Permalink
Make textureLoad/Gather/Compare not load weights
Browse files Browse the repository at this point in the history
textureLoad and textureGather and textureGatherComapre do not use GPU mix weights
so don't load them. This will make the these test run on Intel Mac
compute stage where the weights are bad.
  • Loading branch information
greggman committed Oct 30, 2024
1 parent 32f8ad2 commit 959b539
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ export function skipIfTextureFormatNotSupportedNotAvailableOrNotFilterable(
}
}

const builtinNeedsMipGradientValues = (builtin: TextureBuiltin) =>
builtin !== 'textureLoad' && builtin !== 'textureGather' && builtin !== 'textureGatherCompare';

/**
* Splits in array into multiple arrays where every Nth value goes to a different array
*/
Expand Down Expand Up @@ -2130,7 +2133,9 @@ export async function checkCallResults<T extends Dimensionality>(
gpuTexture?: GPUTexture
) {
const stage = kShortShaderStageToShaderStage[shortShaderStage];
await initMipGradientValuesForDevice(t, stage);
if (builtinNeedsMipGradientValues(calls[0].builtin)) {
await initMipGradientValuesForDevice(t, stage);
}

let haveComparisonCheckInfo = false;
let checkInfo = {
Expand Down

0 comments on commit 959b539

Please sign in to comment.