Skip to content

Commit

Permalink
Reduce default maxSubcasesInFlight instead of using batching (#4006)
Browse files Browse the repository at this point in the history
I forgot that we could adjust maxSubcasesInFlight to avoid problems with
there being too many subcases in a case.

This reverts commit ec54937 as well as
changes the default value for maxSubcasesInFlight.
  • Loading branch information
kainino0x authored Oct 16, 2024
1 parent 648e056 commit ecefa0d
Show file tree
Hide file tree
Showing 66 changed files with 111 additions and 175 deletions.
2 changes: 1 addition & 1 deletion src/common/framework/test_config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export type TestConfig = {

export const globalTestConfig: TestConfig = {
enableDebugLogs: false,
maxSubcasesInFlight: 500,
maxSubcasesInFlight: 100,
testHeartbeatCallback: () => {},
noRaceWithRejectOnTimeout: false,
unrollConstEvalLoops: false,
Expand Down
220 changes: 110 additions & 110 deletions src/resources/cache/hashes.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kAllNumericScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const additionalRangeForType = rangeForType(
);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const kValuesTypes = objectsToRecord([
]);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConcreteIntegerScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConcreteIntegerScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConcreteIntegerScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ function quantizeFunctionForScalarType(type: ScalarType): QuantizeFunc<number> {
}

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValuesTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() inputs rejects invalid values
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValidArgumentTypes = objectsToRecord(kConvertableToFloatScalarsAndVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const g = makeTestGroup(ShaderValidationTest);
const kValidArgumentTypes = objectsToRecord(kConvertableToFloatVectors);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() never errors
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ const valueForType = rangeForType(
);

g.test('values')
.batch(125)
.desc(
`
Validates that constant evaluation and override evaluation of ${builtin}() rejects invalid values
Expand Down
Loading

0 comments on commit ecefa0d

Please sign in to comment.