Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse color attachment cases to sample_mask alphaToCoverage test #2393

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shrekshao
Copy link
Contributor

@shrekshao shrekshao commented Mar 9, 2023

Issue: #2201


Win D3D12 and Linux Vulkan, the alphaToCoverage mask still uses shader output to target[0].alpha value. (test passes)

On Mac Metal, it looks like when target[0] is empty, it always uses alpha = 1 for the alphaToCoverage mask

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@shrekshao shrekshao force-pushed the sparse-color-alpha-to-coverage branch from 73fb11a to 85a40bc Compare March 15, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant