Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bytesPerBlock refactors; generalize validation,image_copy,buffer_related over aspects #3490

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

bytesPerBlock refactors; generalize validation,image_copy,buffer_related over aspects #3490

wants to merge 4 commits into from

Commits on Mar 12, 2024

  1. Refactor more easy cases of bytesPerBlock

    @kainino0x
    kainino0x committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    cc2dfd6 View commit details
    Browse the repository at this point in the history

  2. Add unit tests for resolvePerAspectFormat

    @kainino0x
    kainino0x committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c5a2ecf View commit details
    Browse the repository at this point in the history

  3. Generalize validation,image_copy,buffer_related over aspects 

    - Test a few depth/stencil formats that weren't in kSizedTextureFormats
  (depth24plus-stencil8 stencil, depth32float-stencil8 depth+stencil)
- Parameterize over aspect (depth-only/stencil-only/all)
- Reduce some overparameterization to make up for it (net ~3x faster)

Removes a use of the deprecated .bytesPerBlock.
    @kainino0x
    kainino0x committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ca16d20 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. lint

    @kainino0x
    kainino0x committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3d71fd3 View commit details
    Browse the repository at this point in the history