Add textureSampleCompare/Level WGSL tests #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekshao
approved these changes
Oct 7, 2024
src/webgpu/shader/execution/expression/call/builtin/texture_utils.ts
Outdated
Show resolved
Hide resolved
The tests fill depth textures with random values except, if the comparision mode is 'equal' or 'not-equal' then we only put 0.0, 0.5, 1.0 in the texture. depthRef for all tests are 0.0, 0.5, or 1.0 so the comparisons should produce valid tests.
greggman
force-pushed
the
textureSampleCompare
branch
from
e7392e7
to
c91fd73
Compare
greggman
added a commit
to greggman/cts
that referenced
this pull request
Oct 8, 2024
The tests fill depth textures with random values except, if the comparision mode is 'equal' or 'not-equal' then we only put 0.0, 0.6, 1.0 in the texture. depthRef for all tests are 0.0, 0.5, or 1.0 so the comparisons should produce valid tests.
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
The tests fill depth textures with random values except, if the comparision mode is 'equal' or 'not-equal' then we only put 0.0, 0.6, 1.0 in the texture. depthRef for all tests are 0.0, 0.5, or 1.0 so the comparisons should produce valid tests.
teoxoy
pushed a commit
to mozilla/gpuweb-cts
that referenced
this pull request
Oct 25, 2024
The tests fill depth textures with random values except, if the comparision mode is 'equal' or 'not-equal' then we only put 0.0, 0.6, 1.0 in the texture. depthRef for all tests are 0.0, 0.5, or 1.0 so the comparisons should produce valid tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests fill depth textures with random values
except, if the comparison mode is 'equal' or 'not-equal' then we only put 0.0, 0.5, 1.0 in the texture. depthRef for all tests are 0.0, 0.5, or 1.0 so the comparisons should produce valid tests.
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.