Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WGSL texture builtins all stages #3986

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Oct 8, 2024

Test texture builtins on all stages. Previously
only the fragment stage was tested.

Note: Some of these are expected to fail on Intel Mac Chrome and Firefox because in compute shaders, Intel Mac doesn't do bilinear interpolation between mip levels. At least not if not using argument buffers like Safari does.

Also, stage is the first parameter so all expectations will need to be updated in Chrome's expectations.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Test texture builtins on all stages. Previously
only the fragment stage was tested.

Note: Some of these are expected to fail on Intel Mac
because in compute shaders, Intel Mac doesn't do
bilinear interpolation between mip levels. At least
not if not using argument buffers.
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greggman greggman merged commit d48c080 into gpuweb:main Oct 9, 2024
1 check passed
@greggman greggman deleted the texture-builts-stages branch October 9, 2024 01:49
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
Test texture builtins on all stages. Previously
only the fragment stage was tested.

Note: Some of these are expected to fail on Intel Mac
because in compute shaders, Intel Mac doesn't do
bilinear interpolation between mip levels. At least
not if not using argument buffers.
teoxoy pushed a commit to mozilla/gpuweb-cts that referenced this pull request Oct 25, 2024
Test texture builtins on all stages. Previously
only the fragment stage was tested.

Note: Some of these are expected to fail on Intel Mac
because in compute shaders, Intel Mac doesn't do
bilinear interpolation between mip levels. At least
not if not using argument buffers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants