attemptGarbageCollection periodically (every N subcases) #4007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs attemptGarbageCollection() after every N subcases (5000 by default)
The subcase counting is global so this introduces a little variance from run to run. Alternative would be: Attempt GC at the end of every case (this seems too often), plus attempt GC every N subcases within a case so it's more deterministic. But it's still not totally deterministic because the subcases are running concurrently.
For
webgpu:shader,validation,expression,call,builtin,faceForward:*
(26336 subcases) in Chrome (very rough because the numbers were not coming out very clean):--js-flags=--expose-gc
Issue: Next attempt at #4006 to fix OOMs seen in https://crbug.com/373485785
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.