Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test non-filterable textures can't be used with filtering sampler. #4031

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Nov 5, 2024

IIUC these tests are missing from the CTS

Note that if u32/i32 are removed from textureGather then there is no other texture builtin that uses u32/i32 except textureLoad

Testing locally on Chrome with this patch check does this validation they pass.
With this patch that does this validation but allows depth with a deprecation warning they all pass except for depth. On Chrome Canary with neither patch they all fail except for the f32 tests which are supposed to work.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman enabled auto-merge (squash) November 5, 2024 17:27
@greggman greggman merged commit 8a80203 into gpuweb:main Nov 5, 2024
1 check passed
@greggman greggman deleted the non-filterable-texture branch November 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants