feat(vars-builder-generator): Adding vars_create_factories to ferry_generator|graphql_builder
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for verdant-brigadeiros-5171fa canceled.
|
|
Hi and Servus ;)! Thanks for the PR, I'll release a new version of the code builder so that the PR can succeed. And thanks for the additional documentation. ferry relies on conventional commits to automatically generate changelogs, so please add |
|
also, please update your PR from the master branch, analyze fails because of a new lint |
|
Ah, I see that gql_code_builder actually has breaking changes, since a new required parameter was added. so i published it at 0.10.0, not 0.9.2. |
caffeineflo
changed the title
vars_create_factories to ferry_generator|graphql_buildervars_create_factories to ferry_generator|graphql_builder
caffeineflo
force-pushed
the
fh/ferry-codegen-factories
branch
from
b37ac8c to
e573084
Compare
|
I think I have all things fixed now, so should be good to go if the CI gods decide to approve of these changes as well! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello/Hallo/Servus/Grüß Gott @knaeckeKami,
Now that gql-dart/gql#434 is merged, I thought I'll hold true to my word and open this PR to hover up the newly introduced
vars_create_factoriesoption to Ferry!This PR relies on a new version release of the
gqlpackage though, that still needs to be released and assumes it's going to be version 0.9.2 - let me know if you you prefer a different way of doing this.While writing the docs for this new version, I also noticed that the new
tristate_optionalsoption was missing in the docs, so I took the liberty to add that as well - hope you don't mind!Let me know if anything else needs to be changed!
Thanks!