-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix/reuse-fragments) New test case for issue with implementing not existing classes #438
(fix/reuse-fragments) New test case for issue with implementing not existing classes #438
Conversation
you can use
and then when you are done
|
Oh, that's something new to me and It works. Thanks! ❤️ But I see that my case doesn't produce an error right now. So I have to dive into it again. I will let you know when it's ready. |
probably because end_to_end_test is not using reuse_fragments right now. But that's fine, we can just use this query a test case for #417 |
My mistake... I've created a branch using #417 instead of your https://github.com/gql-dart/gql/tree/repro_reuse_fragments I can create a proper one tomorrow 😞 but it was also true :D
|
…' into reuse-fragments-inline-new-test-case
@knaeckeKami now it's fine. I mean now after enabling reuse_fragments |
Thanks! it will probably show that error on #417 though, which master does not have yet. but that will it make easier figure it out |
pls run code generation so that the generated code is check into the end to end test |
Sure. @knaeckeKami Should I run it with |
For now, it's sufficient to run it with reuse_fragments disabled. When we officially ship this, we can think about proper test coverage of code gen with and without reuse_fragment |
@knaeckeKami done 👌 |
76306e5
into
gql-dart:repro_reuse_fragments
@knaeckeKami as you wanted I added a new test case that doesn't work in my case.
I am not sure if it's done as you prefer and I was not able to test it using that repository, because as I saw it doesn't use local versions of packages and instead it uses versions from pub.dev and unfortunately I haven't found a quick way to overcome it 😅