Add CI workflows #73
Open
Add CI workflows #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhia-gharsallaoui maybe we can use the mage file in CI flow? LGTM otherwise! |
cosmic-chichu
previously approved these changes
Sep 21, 2022
vigith
reviewed
Sep 22, 2022
.github/workflows/go.yml
Outdated
| run: go build -v ./... | ||
|
|
||
| - name: Test | ||
| run: go test -v ./... |
There was a problem hiding this comment.
use mage, e.g., mage test and same for build too
There was a problem hiding this comment.
Done to test, but I kept the go build to build in multi-OS.
WDYT @vigith @cosmic-chichu ?
dhia-gharsallaoui
force-pushed
the
master
branch
from
28622ef
to
05d8bb8
Compare
|
@dhia-gharsallaoui fixed magefile for build #74 |
.github/workflows/go.yml
Outdated
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Build | ||
| run: go build -v ./... |
There was a problem hiding this comment.
we could use mage -v build here, since #74 is merged
dhia-gharsallaoui
force-pushed
the
master
branch
from
7e77225
to
47e7ef2
Compare
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| goos: ['android', 'linux', 'solaris', 'illumos', 'dragonfly', 'freebsd', 'openbsd', 'plan9', 'windows', 'darwin', 'netbsd'] |
There was a problem hiding this comment.
@cosmic-chichu we can limit the OS list and go version in build. Any proposition ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.