Update discovery.kubernetes.md #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect.
|
|
clayton-cornell
added
type/docs
|
@grafana/grafana-agent-maintainers Can someone from the team double check the River example and approve. |
|
@dhalperin Thanks for your input here. Can you review and commit the suggestions. I could do it, but it's nice if you can see what has been suggestions before the PR disappears into the merge history :-) I'll merge once you've had a chance to see/review things here. |
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
Co-authored-by: Mischa Thompson <[email protected]>
|
Edits looked good so committed the changes. Feel free to merge when ready. |
clayton-cornell
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Looks good
@dhalperin I'll get this merged and published :-)
grafanabot
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> (cherry picked from commit 3e2c52f)
grafanabot
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> (cherry picked from commit 3e2c52f)
grafanabot
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> (cherry picked from commit 3e2c52f)
clayton-cornell
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> (cherry picked from commit 3e2c52f) Co-authored-by: Devin H <[email protected]>
clayton-cornell
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> (cherry picked from commit 3e2c52f) Co-authored-by: Devin H <[email protected]>
clayton-cornell
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]> (cherry picked from commit 3e2c52f) Co-authored-by: Devin H <[email protected]>
dwalker-sabiogroup
pushed a commit
to dwalker-sabiogroup/agent
that referenced
this pull request
Jul 28, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]>
clayton-cornell
added a commit
that referenced
this pull request
Aug 14, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]>
clayton-cornell
added a commit
that referenced
this pull request
Aug 14, 2023
* Update discovery.kubernetes.md Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect. * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Clayton Cornell <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Update docs/sources/flow/reference/components/discovery.kubernetes.md Co-authored-by: Mischa Thompson <[email protected]> * Minor fix to remove full stop --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Mischa Thompson <[email protected]>
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added selectors section to the Limited Searched Namespaces section and changed the description of the section to add the specific labels aspect.
PR Description
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist