Skip to content

Commit

Permalink
mimir.rules.kubernetes: explicitely mark the component as healthy on …
Browse files Browse the repository at this point in the history
…successful startup.

If the startup temporarily fails, the component is marked as unhealthy
and the startup is retried indefinitely until it succeeds.
If it succeeds, the component would remain unhealthy.

This change explicitly mark the component as healthy
to fix it.
  • Loading branch information
nicolasvan committed Feb 11, 2025
1 parent f0211d0 commit 71705b5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ Main (unreleased)
- Fixed an issue in the `prometheus.exporter.postgres` component that would leak goroutines when the target was not reachable (@dehaansa)
- Fixed an issue in the `otelcol.exporter.prometheus` component that would set series value incorrectly for stale metrics (@YusifAghalar)

- Fixed an issue in the `mimir.rules.kubernetes` component that would keep the component as unhealthy even when it managed to start after temporary errors (@nicolasvan)

- Fixed issue with reloading configuration and prometheus metrics duplication in `prometheus.write.queue`. (@mattdurham)

- Fixed an issue in the `otelcol.processor.attribute` component where the actions `delete` and `hash` could not be used with the `pattern` argument. (@wildum)
Expand Down
1 change: 1 addition & 0 deletions internal/component/mimir/rules/kubernetes/rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ func (c *Component) startupWithRetries(ctx context.Context, leader leadership, s
level.Error(c.log).Log("msg", "starting up component failed, will retry", "err", err)
health.reportUnhealthy(err)
} else {
health.reportHealthy()
break
}
startupBackoff.Wait()
Expand Down

0 comments on commit 71705b5

Please sign in to comment.