Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove classic modules #20

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Remove classic modules #20

merged 2 commits into from
Mar 1, 2024

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Mar 1, 2024 •
edited
Loading

This PR:

  • Removes the ability for users to configure classic module loaders (module.string, module.file, module.git, module.http)
  • Removes documentation for the removed components
  • Removes documentation referencing "classic modules"

However, the code which enables classic modules has not been removed; this removal will come in a future clean-up effort.

@rfratto
component: remove classic module.* components
0fba35c 
Remove the deprecated classic module.* components. The files have been
moved to testcomponents/ as there are still valuable tests that depend
on them; these can be removed in the future.
@rfratto
docs: remove docs for classic modules
622a07a
clayton-cornell
clayton-cornell approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Mar 1, 2024
@rfratto rfratto merged commit 7e6bd2f into main Mar 1, 2024
9 of 10 checks passed
@rfratto rfratto deleted the remove-classic-modules branch March 1, 2024 18:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clayton-cornell clayton-cornell clayton-cornell approved these changes

Assignees
No one assigned
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfratto @clayton-cornell