-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support kubernetes_role argument for prometheus.operator.servicemonitors #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
clayton-cornell
previously approved these changes
Nov 4, 2024
docs/sources/reference/components/prometheus/prometheus.operator.servicemonitors.md
Outdated
Show resolved
Hide resolved
clayton-cornell
dismissed
their stale review
November 4, 2024 18:09
Clicked approve instead of comment
…or.servicemonitors.md Co-authored-by: Clayton Cornell <[email protected]>
@clayton-cornell can you help take a look again |
clayton-cornell
added
the
type/docs
Docs Squad label across all Grafana Labs repos
label
Nov 6, 2024
Docs look OK. Over to @grafana/grafana-alloy-maintainers for a code review. |
thampiotr
reviewed
Nov 7, 2024
docs/sources/reference/components/prometheus/prometheus.operator.servicemonitors.md
Outdated
Show resolved
Hide resolved
thampiotr
reviewed
Nov 7, 2024
docs/sources/reference/components/prometheus/prometheus.operator.servicemonitors.md
Outdated
Show resolved
Hide resolved
…or.servicemonitors.md Co-authored-by: Piotr <[email protected]>
thampiotr
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
vaxvms
pushed a commit
to vaxvms/alloy
that referenced
this pull request
Nov 15, 2024
…ors (grafana#2023) * Support kubernetes_role argument for prometheus.operator.servicemonitors * Update docs/sources/reference/components/prometheus/prometheus.operator.servicemonitors.md Co-authored-by: Clayton Cornell <[email protected]> * Use DefaultArguments to handle default * Fix doc * Update docs/sources/reference/components/prometheus/prometheus.operator.servicemonitors.md Co-authored-by: Piotr <[email protected]> * Add validation --------- Co-authored-by: Clayton Cornell <[email protected]> Co-authored-by: Piotr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for endpointslice role in
prometheus.operator.servicemonitors
. Before this PR, the role defaults to endpoints. So there was no way to have servicemonitor to scrape an endpointslice in alloy.Example config in alloy after this PR.
Which issue(s) this PR fixes
Fixes #1714
Notes to the Reviewer
PR Checklist