Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loki.secretfilter: Add SPDX header #2028

Merged
merged 2 commits into from
Nov 5, 2024
Merged

loki.secretfilter: Add SPDX header #2028

merged 2 commits into from
Nov 5, 2024

Conversation

romain-gaillard
Copy link
Contributor

PR Description

Adds a SPDX header to gitleaks.toml

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

@romain-gaillard romain-gaillard marked this pull request as ready for review November 4, 2024 18:50
@romain-gaillard romain-gaillard requested a review from a team as a code owner November 4, 2024 18:50
RichiH
RichiH approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@RichiH RichiH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also create a LICENSING.MD in the root of the project Git.

Otherwise LGTM taking the inline suggestion into account.

internal/component/loki/secretfilter/gitleaks.toml Outdated Show resolved Hide resolved
@wildum wildum merged commit 5f0c760 into main Nov 5, 2024
18 checks passed
@wildum wildum deleted the romain-gaillard-patch-1 branch November 5, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildum wildum wildum approved these changes

@RichiH RichiH RichiH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romain-gaillard @RichiH @wildum