troubleshoot drone #2037
Merged
troubleshoot drone #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
force-pushed
the
thampiotr/try-fix-windows-build
branch
3 times, most recently
from
297f7ab
to
b8096e9
Compare
thampiotr
force-pushed
the
thampiotr/try-fix-windows-build
branch
from
b8096e9
to
b1ffa4a
Compare
wildum
approved these changes
Nov 5, 2024
This reverts commit 942317d.
|
This now works! |
thampiotr
commented
Nov 5, 2024
Comment on lines
+167
to
+170
| if runtime.GOOS == "windows" { | ||
| // TODO: Fix this test as we mature the file queue | ||
| t.Skip("This test is very flaky on Windows. Will need to fix it as we mature the filequeue.") | ||
| } |
There was a problem hiding this comment.
cc @mattdurham I didn't have time to investigate it further while doing the release. Was failing quite consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have worked when I temporarily enabled building on PRs (See first commit), I'm not sure if it's a fluke though.
May be worth merging to main to fix?