Run all unit tests on the main branch in GitHub actions. #2528
Conversation
| with: | ||
| go-version-file: go.mod | ||
| # TODO: Enable caching later. | ||
| cache: false |
There was a problem hiding this comment.
While I was testing these changes, the runners ran out of disk space. Then I disabled the caching and they worked fine.
Caches tend to be specific to branches and workflows... there are also race conditions if steps within a workflow run concurrently. For example:
actions/setup-go#358
https://github.com/actions/setup-go/pull/416/files
OTel doesn't use the setup-go cache, instead they use the generic caching action. They run it at the start of the workflow and all other workflow steps wait for it to complete before running. This looks like a better approach, but I'd like us to test it first.
For such an essential and widely used feature, it appears really complicated to configure it the right way.
There was a problem hiding this comment.
we use it for the integration tests and I think that so far it worked well but maybe it was not a problem because we had less workflow. I'm happy to leave it disabled for now but we should keep it in the radar because 20mins to run the tests is a lot
A GitHub action which runs `make test`. The corresponding Drone pipeline can be removed later on.
ptodev
force-pushed
the
ptodev/gh-actions-tests-full
branch
from
2fa5123 to
1997c99
Compare
A GitHub action which runs
make test. The corresponding Drone pipeline can be removed later on.