-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ScrapeConfig CRD to prometheus.operator
#2638
base: main
Are you sure you want to change the base?
Conversation
d397209
to
0d8558e
Compare
prometheus.operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc suggestions are almost all style related to align with incoming style changes for the component docs.
The two important questions that need clarification are:
- Is this an Experimental, Public preview, or GA component?
- Is this a Community supported component?
description: Learn about prometheus.operator.scrapeconfigs | ||
title: prometheus.operator.scrapeconfigs | ||
--- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this one be a Community supported component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am definitively not the authority to answer this questions :-). However, reading https://github.com/grafana/alloy/blob/main/docs/developer/adding-community-components.md my intuition is that it should have the same status as the other prometheus.operator
components (servicemonitors
, podmonitors
and probes
).
Some additional thoughts/checks regarding https://github.com/grafana/alloy/blob/main/docs/developer/adding-community-components.md:
The community components category is mainly targeted at vendor-specific components for which Grafana does not offer commercial support (for example the Datadog exporter).
It's neither vendor specific nor proprietary, and I assume we can safely say that those Prometheus Operator CRDs are kind of an open (source) de-facto standard.
Avoid overlapping functionalities.
AFAIK, this component closed a feature gap and I am not aware of overlapping functionalities.
Avoid components that can be implemented as modules.
AFAIK, this component closed a feature gap and I am not aware of achieving the same with modules.
Avoid components that affect our dependencies in an undesired way, such as pulling in an incompatible version or bloating the collector.
Should be OK, as it depends on the same dependencies as the other prometheus.operator
components.
Make sure that the code licenses are compatible with Alloy's [license](https://github.com/grafana/alloy/blob/main/LICENSE).
Should be OK, as it depends on the same dependencies as the other prometheus.operator
components.
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/prometheus/prometheus.operator.scrapeconfigs.md
Outdated
Show resolved
Hide resolved
Clicked the wrong button in the review screen.
a147023
to
4be40b5
Compare
Fixes grafana#1428 Signed-off-by: alex-berger <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Co-authored-by: Clayton Cornell <[email protected]>
…or.scrapeconfigs.md Signed-off-by: alex-berger <[email protected]>
Signed-off-by: alex-berger <[email protected]>
4be40b5
to
be398d5
Compare
PR Description
Adding support for ScrapeConfig, initially only supporting StaticConfig.
Feedback and guidance highly appreciated.
Which issue(s) this PR fixes
Fixes #1428
Notes to the Reviewer
PR Checklist