remotecfg: bump protocol version, use GET requests #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
Signed-off-by: Paschalis Tsilias <[email protected]>
tpaschalis
force-pushed
the
bump-remotecfg-proto-version
branch
from
6b9f88a to
45a15ad
Compare
erikbaranowski
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR bumps the version of the protocol version used by the remotecfg service to v0.0.10. The new version introduces a new
LocalAttributesfield to deprecateAttributes.Which issue(s) this PR fixes
None filed.
Notes to the Reviewer
cc @erikbaranowski who gathered consensus for the rename. My gut says to not break anything on the Alloy side and leave the 'attribute' field as-is. What do you think?
cc @spartan0x117 since we're changing the remotecfg service, I thought to add connect.WithHTTPGet to take advantage of the idempotency of the GetConfig request. I think you've looked into this in the past right?
PR Checklist