Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimir.rules.kubernetes: explicitely mark the component as healthy on successful startup. #2697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nicolasvan
Copy link

PR Description

If the startup temporarily fails, the component is marked as unhealthy and the startup is retried indefinitely until it succeeds. When it succeeds, the component still remains unhealthy.

This change explicitly mark the component as healthy to fix it.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

…successful startup.

If the startup temporarily fails, the component is marked as unhealthy
and the startup is retried indefinitely until it succeeds.
If it succeeds, the component would remain unhealthy.

This change explicitly mark the component as healthy
to fix it.
@nicolasvan nicolasvan requested a review from a team as a code owner February 11, 2025 17:03
@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants