database_observability: don't error out for insert with values
#2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statements like `insert into table values (...)` were logging an error even though the tables were correctly parsed.
cristiangreco
force-pushed
the
cristian/dbo11y-fix-insert-with-values
branch
from
73420ad to
c979c33
Compare
cristiangreco
commented
Feb 13, 2025
| @@ -226,6 +226,8 @@ func (c QuerySample) tablesFromQuery(digest string, stmt sqlparser.Statement) [] | |||
| case *sqlparser.Insert: | |||
| parsedTables = []string{c.parseTableName(stmt.Table)} | |||
| switch insRowsStmt := stmt.Rows.(type) { | |||
| case sqlparser.Values: | |||
| // ignore raw values | |||
There was a problem hiding this comment.
Don't need to update tests as with this change we're just going to skip a log -- the statement was already parsed correctly.
cristiangreco
requested review from
matthewnolf and
fridgepoet
as code owners
matthewnolf
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Statements like
insert into table values (...)were logging an error even though the tables were correctly parsed.Which issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist