Test Loki client integration. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeschkies
commented
Nov 5, 2024
| from requests import Response | ||
|
|
||
|
|
||
| # TODO: contribute to testcontainers modules |
There was a problem hiding this comment.
Once this lands I'd like to contribute it upstream to https://github.com/testcontainers/testcontainers-python/tree/main/modules
There was a problem hiding this comment.
According to testcontainers/testcontainers-python#733 they might not accept it because it's too simple 🤷
jeschkies
force-pushed
the
karsten/test-integration
branch
from
efcbfcc to
fab62e6
Compare
thepalbi
approved these changes
Nov 5, 2024
| """This method starts the Loki container and runs the readniness check | ||
| to verify that the container is ready to use.""" | ||
| super().start() | ||
| self._readiness_check() |
There was a problem hiding this comment.
According to this it has a 120s timeout, should we do less?
There was a problem hiding this comment.
Loki does take a while to become ready.
| return loki.get_client() | ||
|
|
||
|
|
||
| def test_push(client: LokiClient): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change formats the test code and introduces a Loki testcontainer that's used in a simple Loki client push integration test.
Closes https://github.com/grafana/grafana-csp-app/issues/225