Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow LimitEditor to go to 0 to exclude LIMIT #619

Merged
merged 98 commits into from
Dec 6, 2023
Merged

Allow LimitEditor to go to 0 to exclude LIMIT #619

merged 98 commits into from
Dec 6, 2023

Conversation

SpencerTorres
Copy link
Collaborator

@SpencerTorres SpencerTorres commented Dec 5, 2023 •
edited
Loading

Originally this PR was to group multiple small fixes, but now it's just a one character change. I will open separate PRs later for other bug fixes as needed

@SpencerTorres
checkpoint for v4 restructure + layout changes
0f0c0f7 
may contain bugs. definitely contains bugs.
@SpencerTorres
checkpoint for simplified logic and layout changes
cf224ec
@SpencerTorres
builder options, column metadata, added editors
2d59885
@SpencerTorres
move v4 components into original directories
d5fd401
@SpencerTorres
fix: component tests, query generator
8bcd996
@SpencerTorres
change: version, Http, refactor EditorTypeSwitcher
43dc31f
@SpencerTorres
ReadonlyArray table columns, remove exception
e58e25c
@SpencerTorres
update new selectors
b827507
@SpencerTorres
split time column check
060177d
@SpencerTorres
default db, remove useless "if"
80c2b41
@SpencerTorres
inline conditional component, fix test
625d212
@SpencerTorres
added tests, comments
48e5ad9
@SpencerTorres
tests for OtelVersionSelect and getColumnByHint
a81eb1f
@SpencerTorres
re-enable orderBby option filter logic
fe3bfdb
@SpencerTorres
preserve column state when selection is updated
1cbf406
@SpencerTorres
trace query generator
2f9d912
@SpencerTorres
traceID, collapsable sections
68c4e4c
@SpencerTorres
change incorrect sql function
e592872
@SpencerTorres
add generic trace filters
3505230
@SpencerTorres
fix explore view panel format
837ad2d
@SpencerTorres
logs query generator
cf6acd0
@SpencerTorres
fix sql editor explore view
313d574
@SpencerTorres
auto select logs columns from otel config
2f8ea6e
@SpencerTorres
filter column types
0a15e7e
@SpencerTorres
fix warnings/tests
8318481
@SpencerTorres
fix lint errors
a902745
@SpencerTorres
fix default editor type
2345692
@SpencerTorres
upgrade dependencies
08b8959
@SpencerTorres
config view changes
b9fb80f
@SpencerTorres
Update query builder/sqlGenerator with new state/config changes
b7ee093
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SpencerTorres SpencerTorres added type/bug Something isn't working enhancement New feature or request effort/small labels Dec 5, 2023
@SpencerTorres SpencerTorres marked this pull request as ready for review December 6, 2023 17:05
@SpencerTorres SpencerTorres requested a review from a team as a code owner December 6, 2023 17:05
@SpencerTorres SpencerTorres requested review from asimpson, bossinc, aangelisc and adamyeats and removed request for a team, asimpson, aangelisc and adamyeats December 6, 2023 17:05
@SpencerTorres SpencerTorres changed the title v4.0.0-beta updates & bug fixes Allow LimitEditor to go to 0 to exclude LIMIT Dec 6, 2023
@bossinc bossinc merged commit 65c4d6b into grafana:v4.x Dec 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bossinc bossinc bossinc approved these changes

Assignees
No one assigned
Labels
effort/small enhancement New feature or request type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpencerTorres @CLAassistant @bossinc