Custom HTTP Headers #633
Closed
Custom HTTP Headers #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpencerTorres
requested review from
asimpson,
bossinc,
aangelisc and
adamyeats
and removed request for
a team
|
@SpencerTorres Thanks for this! It looks like there's a bunch of extra historical commits on this branch, would you be able to look into this? |
|
This was developed on the v4 branch which is what I'm merging in to. The file changes look correct, but I think all the commits were squashed in that first v4.x PR edit: Did some git surgery and removed the un-squashed commits |
jkaflik
suggested changes
Dec 19, 2023
There was a problem hiding this comment.
I've left one detail, but it's quite important.
BTW should this be mentioned in README? Would be great if we mention how to use it in JSON configuration: https://github.com/grafana/clickhouse-datasource?tab=readme-ov-file#with-a-configuration-file
SpencerTorres
force-pushed
the
custom-http-headers
branch
from
764ad8f to
4d7690b
Compare
Merged
asimpson
requested changes
Jan 31, 2024
|
Fixed the input box width for small screens, thanks! |
asimpson
approved these changes
Feb 1, 2024
|
Closing since this was included in #666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows adding custom HTTP headers. (Requested in #626)
jsonData.jsonData.secureJsonData.Includes frontend + backend changes.
Also includes some label updates to the config page when selecting a port.