Do not control SqlEditor height #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asimpson
requested changes
Feb 13, 2024
Co-authored-by: Adam Simpson <[email protected]>
asimpson
approved these changes
Feb 14, 2024
|
@asimpson, did the last failing check happen due to a lack of access to credentials? Can we merge the PR? |
|
@mshustov Looks like it. The build passed though which is what I care about. Can you merge |
|
@asimpson could you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #684
There is a bug in logic that on every change in the editor calls
saveChanges({expand:true}), which resets therawSqlvalue back to the original state.Instead of fixing this bug, I checked how Grafana handles this logic itself. From this example, it looks like the built-in Grafana editor handles height updates inside
CodeEditorcomponent, so I removed the external logic to manage component height.Changelog
Remove manual expansion of SqlEditor.