Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trace_start and trace_end changes from #890 #904

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Fix trace_start and trace_end changes from #890 #904

merged 4 commits into from
Jul 11, 2024

Conversation

SpencerTorres
Copy link
Collaborator

@SpencerTorres SpencerTorres commented Jul 11, 2024 •
edited
Loading

fixes (#900)

changes:

  • Reverted Trace Search back to original timestamp, since that is intended to be human readable
  • Fixed Trace ID mode to use the original DateTime type instead of the float type, which fixes the time range filtering
  • Updated changelog

@SpencerTorres SpencerTorres marked this pull request as ready for review July 11, 2024 04:45
@SpencerTorres SpencerTorres requested a review from a team as a code owner July 11, 2024 04:45
aangelisc
aangelisc approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SpencerTorres! I've tested locally and this all LGTM.

image

@aangelisc aangelisc merged commit 1e96c97 into grafana:main Jul 11, 2024
16 checks passed
@SpencerTorres SpencerTorres deleted the fix-trace-times branch July 11, 2024 18:44
@rudebono
Copy link

Thank you so much ! ⸜(｡˃ ᵕ ˂ )⸝♡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpencerTorres @rudebono @aangelisc