Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map key filtering from showing column name #942

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

SpencerTorres
Copy link
Collaborator

This fixes a regression from #862 that caused the column name to show up in the map key filter dropdown instead of showing the actual key being filtered. The filter still works but it's a confusing visual bug

changes:

  • Map key now correctly shows in filter
  • Updated changelog

broken:
before fix

fixed:
after fix

Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @SpencerTorres!

@aangelisc aangelisc merged commit cd25428 into grafana:main Aug 14, 2024
16 checks passed
@SpencerTorres SpencerTorres deleted the fix-map-filters branch August 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants