Allow empty string values for $__conditionAll macro
#960
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpencerTorres
requested review from
bossinc,
aangelisc,
adamyeats and
katebrenner
aangelisc
reviewed
Aug 28, 2024
|
Hi @SpencerTorres , is there any chance the PR will be merged and available in the upcoming releases? |
|
@sbengo I agree we need to be careful with changing the behavior of this macro, I think we'll follow the suggestion of making a new one for the new behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947 but may also break #262.
It makes sense to allow empty strings for this macro, anyone who wishes to exclude the macro can use
$__allin their query to get the1=1functionality.Changes:
1=1