Extend csplib to add Azure SQL Database #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeyer
force-pushed
the
rgeyer/csp-azuresql-actually
branch
from
075775a
to
8a6e346
Compare
rgeyer
force-pushed
the
rgeyer/csp-azuresql-actually
branch
from
8a6e346
to
720fc62
Compare
v-zhuravlev
reviewed
Jul 26, 2024
Comment on lines
+367
to
+385
| asql_dtutbl: | ||
| this.signals.azuresqldb.dtuUsed.common | ||
| + commonlib.panels.generic.table.base.new( | ||
| 'DTU utilization and limits by database', | ||
| [ | ||
| this.signals.azuresqldb.dtuUsed.asTarget() | ||
| + g.query.prometheus.withFormat('table') | ||
| + g.query.prometheus.withInstant(true), | ||
|
|
||
| this.signals.azuresqldb.dtuPercent.asTarget() | ||
| + g.query.prometheus.withFormat('table') | ||
| + g.query.prometheus.withInstant(true), | ||
|
|
||
| this.signals.azuresqldb.dtuLimit.asTarget() | ||
| + g.query.prometheus.withFormat('table') | ||
| + g.query.prometheus.withInstant(true), | ||
| ], | ||
| 'DTU utilization and limits by database' | ||
| ) + self._asql_tableCommon(), |
There was a problem hiding this comment.
nit: you could also try to define tables with using asTable() and asTableColumn() now:
#1290
v-zhuravlev
reviewed
Jul 26, 2024
Comment on lines
63
to
74
| vCoreCpuPercent: { | ||
| name: 'vCore utilization by database', | ||
| description: 'Percent of CPU utilization by database. If database uses vCores, the vCore percent utilization is shown', | ||
| type: 'gauge', | ||
| unit: 'percent', | ||
| sources: { | ||
| azuremonitor: { | ||
| expr: '100 * (label_replace(azure_microsoft_sql_servers_databases_cpu_used_average_count{%(queriesSelector)s}, "database", "$1", "resourceID", ".+/(.*)") / label_replace(azure_microsoft_sql_servers_databases_cpu_limit_average_count{%(queriesSelector)s}, "database", "$1", "resourceID", ".+/(.*)"))', | ||
| legendCustomTemplate: '{{database}} vCore', | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
type=gauge and aggLevel=none is equivalent of type=raw. Right now it would be just fine, however, changing aggLevel to instance/group later on would break this signal, as 100 * would be applied in the wrong place.
Best to change type to raw, or move 100 * to exprWrappers:
https://github.com/grafana/jsonnet-libs/tree/master/common-lib/common/signal#configuration-options
There was a problem hiding this comment.
Ahh excellent. Thank you for this, I'll add it to the exprWrappers.
v-zhuravlev
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an azure sql database dashboard to csp-mixin.