Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows: Use instance label for hostname in hostname panel #1353

Merged
merged 5 commits into from
Nov 6, 2024
Merged

windows: Use instance label for hostname in hostname panel #1353

merged 5 commits into from
Nov 6, 2024

Conversation

v-zhuravlev
Copy link
Contributor

@v-zhuravlev v-zhuravlev commented Nov 2, 2024 •
edited
Loading

As hostname label is not present in windows_os_info metric.

@v-zhuravlev v-zhuravlev requested a review from a team as a code owner November 2, 2024 14:36
Dasomeone
Dasomeone approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time's the charm Github, please approve this time...

@v-zhuravlev v-zhuravlev merged commit b4993cb into master Nov 6, 2024
6 of 7 checks passed
@v-zhuravlev v-zhuravlev deleted the vzhuralev/windows-fix2 branch November 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dasomeone Dasomeone Dasomeone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-zhuravlev @Dasomeone