Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for empty (filteringSelector='') #1355

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add support for empty (filteringSelector='') #1355

merged 1 commit into from
Nov 12, 2024
+12 −8

Conversation

v-zhuravlev
Copy link
Contributor

@v-zhuravlev v-zhuravlev commented Nov 12, 2024 •
edited
Loading

  1. Add support for empty (filteringSelector='') to support cases when we don't want to have any static filter at all.
    You can now set filteringSelector to ''
    and in queries this:
    {job!="", job=~"$job"}
    would become
    {job=~"$job"}
  2. Turn datasource to prometheus_datasource when loki is enabled this helps to pass dashboard-linter rule:

@v-zhuravlev v-zhuravlev requested a review from a team as a code owner November 12, 2024 11:51
Dasomeone
Dasomeone approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Dasomeone Dasomeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, loving all these improvements!

@v-zhuravlev v-zhuravlev merged commit 5a6b86b into master Nov 12, 2024
4 checks passed
@v-zhuravlev v-zhuravlev deleted the empty-filtering-selector branch November 12, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dasomeone Dasomeone Dasomeone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-zhuravlev @Dasomeone