Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sobek dependency #3985

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Oct 15, 2024

What?

This PR updates the Sobek dependency to its latest version.

Why?

as per our post-release dependency update practice.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3979

@oleiade oleiade requested a review from a team as a code owner October 15, 2024 09:59
@oleiade oleiade requested review from olegbespalov and joanlopez and removed request for a team October 15, 2024 09:59
@joanlopez
Copy link
Contributor

I'm wondering, should we consider updating Sobek (from goja) as well, as part of this process? 🤔
cc/ @mstoykov

joanlopez
joanlopez previously approved these changes Oct 15, 2024
@oleiade oleiade merged commit efe580e into master Oct 17, 2024
23 checks passed
@oleiade oleiade deleted the maintenance/update-dependencies-sobek branch October 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants