Update deps #3987
Open
Update deps #3987
+19,235
−17,347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent release, v1.10.0 is only compatible with the go 1.23 version. At this moment, k6 uses go 1.21, and is therefore not compatible with it yet.
Note that three sub-packages are now considered deprecated and will need some import replacements: github.com/jhump/protoreflect/desc, github.com/jhump/protoreflect/desc/protoparse, and github.com/jhump/protoreflect/dynamic
oleiade
requested review from
olegbespalov and
joanlopez
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR udpates the rest of the dependencies for v0.55.0.
Importantly, some dependencies were not updated in this round because they require a version of Go that's > 1.21:
goquery: not the latest version because 1.23.esbuild: latest versions are only compatible with go1.23 and contain breaking change.oteland its subpackages: require go version 1.22.Furthermore, the
protoreflectpackage has been updated to its latest version. However, as part of the update, some of its packages have been marked as deprecated: github.com/jhump/protoreflect/desc, github.com/jhump/protoreflect/desc/protoparse, and github.com/jhump/protoreflect/dynamic. I'll be creating a dedicated issue to ensure we update our imports accordingly.Why?
As per our release process.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#3979 The most recent release, v1.10.0 is only compatible with the go 1.23
version. At this moment, k6 uses go 1.21, and is therefore not
compatible with it yet.