Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: split error message check to fix it for go 1.24 #4000

Merged
merged 1 commit into from
Oct 21, 2024
Merged

test: split error message check to fix it for go 1.24 #4000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion js/compiler/compiler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ func TestCorruptSourceMap(t *testing.T) {
require.NoError(t, err)

require.Contains(t, msg, `Couldn't load source map for somefile`)
require.Contains(t, msg, `json: cannot unmarshal number into Go struct field v3.mappings of type string`)
// @mstoykov: this is split as message changed in go1.24
require.Contains(t, msg, `json: cannot unmarshal number into Go struct field`)
require.Contains(t, msg, `mappings of type string`)
}

func TestMinimalSourceMap(t *testing.T) {
Expand Down