Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use k6provider #90

Merged
merged 5 commits into from
Jan 29, 2025
Merged

use k6provider #90

merged 5 commits into from
Jan 29, 2025

Conversation

pablochacin
Copy link
Contributor

@pablochacin pablochacin commented Jan 29, 2025

Use k6provider to obtain a k6 binary with the dependencies required for a test.

Breaking changes

  • Removes the option of a local build, as k6provider relies on a k6build service

Changes

  • Removes the option to define the cache directory that stores the binaries. This directory will default to the k6provider's default
  • Removes the automatic cleanup of the binaries. This functionality requires Add function for deleting a binary k6provider#39

Known issues

Notes to reviewers

The change set is quite large but most changes are straightforward and related to the removal of the local build option:

  • Remove the option to specify the catalog URL
  • Remove the option to specify the cache dir
  • Remove references to the removed options in the test setup and assertions
  • setup a local k6build test environment
  • Do not check for binary removal after tests
  • Restructure tests to share same k6build environment

@pablochacin pablochacin marked this pull request as ready for review January 29, 2025 14:12
@pablochacin pablochacin requested a review from a team as a code owner January 29, 2025 14:12
@pablochacin pablochacin requested review from szkiba and removed request for a team and szkiba January 29, 2025 14:12
cmd/cmd_test.go Show resolved Hide resolved
return "", err
}

return binary.Path, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might benefit from doing debug logs (that will be available with increased verbosity -v), like checksum, etc, here and in many other places, like imagine somebody comes to us and says it doesn't work, why? But for sure it out of the scope of this PR

@pablochacin pablochacin merged commit 32d696c into main Jan 29, 2025
7 checks passed
@pablochacin pablochacin deleted the use-k6provider branch January 29, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants