Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(thanos): add migration doc for thanos storage clients #16133
base: main
Are you sure you want to change the base?
docs(thanos): add migration doc for thanos storage clients #16133
Changes from 7 commits
6d970e5
9dc4f36
8298b38
3f705bf
86f416d
8b16e4d
f34fad1
6056a4d
0bc9796
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is confusing to me. Does this whole comment apply to the
service_account
? Shouldn't the input be afile.json
of some sort?Is there a typo at line 30? Should it read
service_account: service-account.json
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only this portion of the comment applies to the
service_account
field. It expects the json contents, not a file path.Rest of the comment mentions how the google SDK picks up credentials either from env or known file locations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i took this content from our configuration reference, didn't trim it down for the sake of completeness. we could rewrite this in both places if its confusing :)
https://grafana.com/docs/loki/next/configure/#thanos_object_store_config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I read this over half a dozen times, and while the commented text made sense to me, I was having trouble match it to the parameter. But reading it over again, I think the commented text is clear enough, i was just stuck trying to match it to the example parameter.
If you don't want to rewrite the comment, maybe change line 31 to read
service_account: your-service-account.json
?